Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show friendly error and prevent NPE when setting invalid QuerySpec options in katharsis boot #373

Closed
2 tasks done
Ramblurr opened this issue Mar 20, 2017 · 0 comments
Closed
2 tasks done

Show friendly error and prevent NPE when setting invalid QuerySpec options in katharsis boot #373

Ramblurr opened this issue Mar 20, 2017 · 0 comments
Labels
easy PR enhancement
Milestone
v.3.0.x

Comments

@Ramblurr
Copy link
Contributor

Ramblurr commented Mar 20, 2017 •
edited
Loading

When you call setDefaultPageLimit or setMaxPageLimit in KatharsisBoot but you are using QueryParam you get an NPE. The developer may not know why this happens.

  • Show friendly error message
  • Add java doc clarifying the situation
Ramblurr pushed a commit that referenced this issue Mar 20, 2017
Show friendly error and prevent NPE when setting invalid QuerySpec op…
73a4a8b 
…tions in katharsis boot #373
@Ramblurr Ramblurr mentioned this issue Mar 20, 2017
Merged
@masterspambot masterspambot added this to the v.3.0.x milestone Mar 20, 2017
Ramblurr pushed a commit that referenced this issue Mar 21, 2017
Show friendly error and prevent NPE when setting invalid QuerySpec op…
50af702 
…tions in katharsis boot #373
chb0github pushed a commit that referenced this issue Mar 24, 2017
@Ramblurr @chb0github
Show friendly error and prevent NPE when setting invalid QuerySpec op…
86c8ec3 
…tions in katharsis boot #373 (#374)
@Ramblurr Ramblurr closed this as completed Apr 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy PR enhancement
Projects
None yet
Milestone
v.3.0.x
Development

No branches or pull requests
2 participants
@Ramblurr @masterspambot