Support Nested Inclusions N Levels Deep

[mitch2na]

Right now nested inclusions only work up to the second level. I am in progress of enhancing the serializer to support inclusion values that are N levels down. For example:

localhost/web/project/1?include=tasks.includedProject.tasks

[chb0github]

I knew of this limitation too and never got around to filing a ticket. Or did I?

[mitch2na]

@chb0github Cool, seems to be working right now, but the serialization code is a bit of nightmare. Going to try and clean it up a bit.

I do have one question, when serializing included data it stops serializing relationship data after the second level. I am guessing it should serialize data as far as it finds it down the chain? Not sure if this might be an issue if some data is self referencing

[chb0github]

It should go all the way down. I had to hard code some IncludeByDefault on
fields I knew our UI used. That serialization code is scary which is why I
didn't take it on

On Wed, Nov 16, 2016, 6:03 PM Nick Mitchell notifications@github.com
wrote:

@chb0github https://github.com/chb0github Cool, seems to be working
great, but the serialization code is a bit of nightmare. Going to try and
clean it up a bit.

I do have one question, when serializing included data it stops
serializing relationship data after the second level. I am guessing it
should serialize data as far as it finds it down the chain? Not sure if
this might be an issue if some data is self referencing

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#214 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABaI0O1jIRFhn-i4sdvlzbH5f9pK3xPkks5q-7XngaJpZM4KyHXl
.

[mitch2na]

@chb0github Haha i know what you mean! Okay i just finished the last commit for this and i think its good to go. Simplified the inclusion and default / lazy serialization code while adding serialization of all relationship objects down the chain.

[chb0github]

Do you have a pr? I can merge it in

On Wed, Nov 16, 2016, 8:46 PM Nick Mitchell notifications@github.com
wrote:

@chb0github https://github.com/chb0github Haha i know what you mean!
Okay i just finished the last commit for this and i think its good to go.
Simplified the inclusion and default / lazy serialization code while adding
serialization of all relationship objects down the chain.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#214 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABaI0F2PFpnhRm-CJ4QRLlanAw_jbyZfks5q-9wQgaJpZM4KyHXl
.

[mitch2na]

@chb0github Sorry merged it in last night, if you want to review it #215