Re-implement config inheritance support after removal of ActiveSupport::Configurable #137
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of our projects (glg, gus, nfsa-pro) use Collections::Base with inheritance. They define an 'ApplicationCollection' with common settings and then inherit from that. Example code:
The expectation being that config in ApplicationCollection is inherited by SomeController::Collection. That doesn't seem to happen, as we use a class variable
@configwhich is not inherited. This PR changes@configto aclass_attribute, anddups it for subclasses. And added some tests.