This repository was archived by the owner on Jun 28, 2024. It is now read-only.
ci: Add CentOS setup script. #207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jodh-intel
reviewed
Apr 4, 2018
.ci/setup_env_centos.sh
Outdated
|
|
||
| # Enable EPEL repository on CentOS | ||
| sudo -E yum install -y wget rpm | ||
| wget http://dl.fedoraproject.org/pub/epel/epel-release-latest-${centos_version}.noarch.rpm |
.ci/setup_env_centos.sh
Outdated
| source "${cidir}/lib.sh" | ||
|
|
||
| # Obtain CentOS version | ||
| centos_version=$(cat /etc/os-release | grep "VERSION_ID" | cut -d '"' -f2) |
There was a problem hiding this comment.
Could be simplified to:
centos_version=$(grep VERSION_ID /etc/os-release | cut -d '"' -f2)
GabyCT
force-pushed
the
topic/addsetupcentos
branch
5 times, most recently
from
d149b9a to
9a5fbd5
Compare
GabyCT
force-pushed
the
topic/addsetupcentos
branch
from
9a5fbd5 to
e7f8738
Compare
This will enable to setup and run kata-runtime in CentOS. Fixes kata-containers#197 Signed-off-by: Gabriela Cervantes <gabriela.cervantes.tellez@intel.com>
chavafg
reviewed
Apr 6, 2018
.ci/lib.sh
Outdated
| go get -d -u -v "$runtime_repo" || true | ||
| [ ! -f "$versions_file" ] && { echo >&2 "ERROR: cannot find $versions_file"; exit 1; } | ||
| yq read "$versions_file" "$dependency" | ||
| if [ "$ID" == "ubuntu" ] || [ "$ID" == "fedora" ]; then |
Contributor
There was a problem hiding this comment.
If you add this condition, centos will not be able to read the version.yaml file and we would not be able to get the versions we need.
.ci/install_qemu.sh
Outdated
|
|
||
| if [ "$ID" == "centos" ]; then | ||
| qemu_path="/usr/local/bin/qemu-system-$(arch)" | ||
| sudo ln -sf "$qemu_path" /usr/bin/ |
Contributor
There was a problem hiding this comment.
I think this is not needed anymore as we are already creating the symlink above. See L40.
Contributor
Author
There was a problem hiding this comment.
@chavafg centos does not retrieve a value with
GabyCT
force-pushed
the
topic/addsetupcentos
branch
2 times, most recently
from
abd8709 to
0a115a9
Compare
Contributor
Author
|
@chavafg changes applied |
Contributor
|
lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will enable to setup and run kata-runtime in CentOS.
Fixes #197
Signed-off-by: Gabriela Cervantes gabriela.cervantes.tellez@intel.com