-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Could not load colour scheme #4
Comments
Ah, that's a useful notice. I'm old and ... well ... I'm using only the old scheme/file format from the beginning of Sublime Text. Maybe this plugin is from the old days and just doesn't understand the "new" format. Likely we don't even need this work-around as Sublime ships with appropriate diff colors since they have the inline diffing/git support. We'll see. |
Since Sublime ships with the basic git support, it also has a diffing feature and with it defines standard colors for inserted/deleted lines or (intra-line) chars. We have `diff.inserted` and `diff.inserted.char` usually in green and `diff.deleted` in red. Every color scheme should already define them. User can change their scheme as usual and change the colors to their liking. Note that I add the suffix `.sbs-compare` to the scopes (e.g. `diff.inserted.sbs-compare`) so users can also target exactly our scopes. Closes #4
Just wanted to say thank you for such a fast fix! It is sincerely appreciated! 🙏 |
Took me a while, but I figured it out. Might be a good idea to give an example in the README. Here's mine: // Documentation at https://www.sublimetext.com/docs/color_schemes.html
{
"variables":
{
},
"globals":
{
},
"rules":
[
{
"scope": "diff.deleted.sbs-compare",
"background": "hsla(360, 60%, 60%, 0.55)",
"foreground_adjust": "l(+ 5%)"
},
{
"scope": "diff.deleted.char.sbs-compare",
"background": "hsla(360, 80%, 60%, 0.90)",
"foreground_adjust": "l(+ 10%)"
},
{
"scope": "diff.inserted.sbs-compare",
"background": "hsla(180, 60%, 60%, 0.35)",
"foreground_adjust": "l(+ 5%)"
},
{
"scope": "diff.inserted.char.sbs-compare",
"background": "hsla(180, 45%, 60%, 0.70)",
"foreground_adjust": "l(+ 10%)"
}
]
}
|
Hello, and it's great to see this in development again.
Ever since I started using this package, I get this error message:
I use the Default Dark theme, and I have also tried setting the 'Select Color Scheme...' and setting it to simply 'Auto'.
I prefer to use Monokai Pro if I can, but I changed it to try and fix this option.
Unfortunately, the behavior continues no matter what I have tried so far, and thus, every time I compare, it errors, and then finally comes to the basic black on white 🤐
Thank you again for developing this, and appreciate any possible help. If you need anything from me let me know.
The text was updated successfully, but these errors were encountered: