Alteration so you can call the scripts from anywhere #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Looks great @martybel! Thanks for the patch! |
kasparsd
added a commit
that referenced
this pull request
Sep 3, 2014
…ndant Alteration so you can call the scripts from anywhere
|
This commit broke the script. The env variables GIT_WORK_TREE and GIT_DIR now point to wp_deploy/git and wp_deploy/git/.git which don't exist. I think they need to be updated to: export GIT_WORK_TREE=${BASEDIR}/../git What do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First thing that i noticed when checking out your setup is that the scripts only seemed to work if they were called from the proper location. This pull request should make the location not important anymore.
Basically it first changes the current dir to the directory of the script itself, before determining a BASEDIR and the SLUG.
All references to dirname $PWD are replaces to BASEDIR to avoid having to figure out where we are every time.