pkg/nanopb: simplify setup procedure #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaspar030
reviewed
Sep 9, 2019
| @@ -15,6 +15,7 @@ $(GENSRC): $(PROTOBUF_FILES) | |||
| $(Q)D=$(BINDIR)/$(MODULE) && \ | |||
| mkdir -p "$$D" && \ | |||
| cd $(CURDIR) && \ | |||
| make -C $(PKGDIRBASE)/nanopb/generator/proto && \ | |||
There was a problem hiding this comment.
can you we guard this with something like if $PROTOC_GEN_NANOPB == $(PKGDIRBASE)/nanopb/generator/protoc-gen-nanopb, so that make will only be called if the user doesn't supply an external version?
Or is that overkill...?
There was a problem hiding this comment.
The question is why would the user ever want to provide an external version?
I can add such check, but I don't quite see the use case for it yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
No need to request manual intervention by the user, your PR already includes everything to make nanopb just work™ with only minor additions.
Testing procedure
Just build
tests/pkg_nanopbIssues/PRs references
RIOT-OS#11565