Added phrase return to @gaming_bot #1
Conversation
untested
| @@ -122,11 +122,20 @@ const deregisterHandler = async (client, msg) => { | |||
| } | |||
| }; | |||
|
|
|||
| const chatHandler = (client, text) => { | |||
| fs.readFile(../chatbot/phraselist.txt, function(err, data){ | |||
There was a problem hiding this comment.
File path is not in a string. This will break
| @@ -122,11 +122,20 @@ const deregisterHandler = async (client, msg) => { | |||
| } | |||
| }; | |||
|
|
|||
| const chatHandler = (client, text) => { | |||
| fs.readFile(../chatbot/phraselist.txt, function(err, data){ | |||
There was a problem hiding this comment.
IF I EVER SEE ANOTHER ANONYMOUS FUNCTION THAT ISN'T AN ARROW FUNCTION YOU ARE BANNED
There was a problem hiding this comment.
| const handlerMap = { | ||
| ".help": helpHandler, | ||
| ".register": registerHandler, | ||
| ".deregister": deregisterHandler, | ||
| ".recognized-command": crawlRequestHandler, | ||
| "@gaming_bot": chatHandler, |
There was a problem hiding this comment.
Overall, I'd prefer all commands that the gamingbot recognizes to begin with the same special character, for continuity.
| @@ -122,11 +122,20 @@ const deregisterHandler = async (client, msg) => { | |||
| } | |||
| }; | |||
|
|
|||
| const chatHandler = (client, text) => { | |||
| fs.readFile(../chatbot/phraselist.txt, function(err, data){ | |||
| var lines = data.split('\n'); | |||
There was a problem hiding this comment.
There are lots of issues with using the keyword var. Use let for variables you will reassign (in the manner of let lines; lines = somethingNew;. Use const for variables you do not plan to reassign.
There was a problem hiding this comment.
| mass murder of gamers | ||
| execute a gamer save a life | ||
| make gaming a felony | ||
| An amateur programmer that will steal your code and call it his own |
There was a problem hiding this comment.
What is the difference between phraselist and phraselist.txt? Only one is probably needed?
untested