Wallet subsystem transaction generator updates #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mpute mass (currently set to 100 on tn10 and tn11)
… potential overflows (re github feedback)
… is None (re GitHub feedback)
michaelsutton
approved these changes
Jan 23, 2024
D-Stacks
pushed a commit
to D-Stacks/rusty-kaspa
that referenced
this pull request
Jan 23, 2024
* replace NetworkType with NetworkId in the tx generator and related APIs * fix url path rendering in format_url * Improve mass related errors * refactor fee handling * renaming fee variants * mass combination strategy * wip - storage mass * additional unit tests and limit checks * Introduce per-network configurable additional compound transaction compute mass (currently set to 100 on tn10 and tn11) * expand sanity checks to handle 0 value outputs * documentation updates * code formatting * Set new input sequence to 0 * change aggregate input value check to use saturating_sub() to prevent potential overflows (re github feedback) * change storage mass fee calc to return u64::MAX if the resulting mass is None (re GitHub feedback)
D-Stacks
pushed a commit
to D-Stacks/rusty-kaspa
that referenced
this pull request
Jan 23, 2024
* replace NetworkType with NetworkId in the tx generator and related APIs * fix url path rendering in format_url * Improve mass related errors * refactor fee handling * renaming fee variants * mass combination strategy * wip - storage mass * additional unit tests and limit checks * Introduce per-network configurable additional compound transaction compute mass (currently set to 100 on tn10 and tn11) * expand sanity checks to handle 0 value outputs * documentation updates * code formatting * Set new input sequence to 0 * change aggregate input value check to use saturating_sub() to prevent potential overflows (re github feedback) * change storage mass fee calc to return u64::MAX if the resulting mass is None (re GitHub feedback)
|
The overall goal appears to be enhancing the transaction generator logic to better handle storage mass, improving the efficiency of execution pathways, and preparing for future changes in mass handling. The inclusion of unit tests and error handling improvements suggests a focus on code reliability and robustness. It's good practice to ensure that code changes are thoroughly tested and errors are handled appropriately. |
KashProtocol
pushed a commit
to Kash-Protocol/rusty-kash
that referenced
this pull request
Feb 26, 2024
* replace NetworkType with NetworkId in the tx generator and related APIs * fix url path rendering in format_url * Improve mass related errors * refactor fee handling * renaming fee variants * mass combination strategy * wip - storage mass * additional unit tests and limit checks * Introduce per-network configurable additional compound transaction compute mass (currently set to 100 on tn10 and tn11) * expand sanity checks to handle 0 value outputs * documentation updates * code formatting * Set new input sequence to 0 * change aggregate input value check to use saturating_sub() to prevent potential overflows (re github feedback) * change storage mass fee calc to return u64::MAX if the resulting mass is None (re GitHub feedback)
smartgoo
pushed a commit
to smartgoo/rusty-kaspa
that referenced
this pull request
Jun 18, 2024
* replace NetworkType with NetworkId in the tx generator and related APIs * fix url path rendering in format_url * Improve mass related errors * refactor fee handling * renaming fee variants * mass combination strategy * wip - storage mass * additional unit tests and limit checks * Introduce per-network configurable additional compound transaction compute mass (currently set to 100 on tn10 and tn11) * expand sanity checks to handle 0 value outputs * documentation updates * code formatting * Set new input sequence to 0 * change aggregate input value check to use saturating_sub() to prevent potential overflows (re github feedback) * change storage mass fee calc to return u64::MAX if the resulting mass is None (re GitHub feedback)
D-Stacks
pushed a commit
to D-Stacks/rusty-kaspa
that referenced
this pull request
Jul 12, 2024
* replace NetworkType with NetworkId in the tx generator and related APIs * fix url path rendering in format_url * Improve mass related errors * refactor fee handling * renaming fee variants * mass combination strategy * wip - storage mass * additional unit tests and limit checks * Introduce per-network configurable additional compound transaction compute mass (currently set to 100 on tn10 and tn11) * expand sanity checks to handle 0 value outputs * documentation updates * code formatting * Set new input sequence to 0 * change aggregate input value check to use saturating_sub() to prevent potential overflows (re github feedback) * change storage mass fee calc to return u64::MAX if the resulting mass is None (re GitHub feedback)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the transaction generator logic to account for storage mass.
The following changes have been made:
Maxwill require updates to unit tests)