Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logger: change log level for "Couldn't find UTXO entry" to debug (and ignore message on orphan transactions) #2108

Merged
merged 8 commits into from
Jun 29, 2022
Merged

Logger: change log level for "Couldn't find UTXO entry" to debug (and ignore message on orphan transactions) #2108

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f406e38
Logger: change log level for "Couldn't find UTXO entry" to debug
D-Stacks Jun 26, 2022
cfc985c
ignore error for orphans
D-Stacks Jun 27, 2022
ea28575
continue also if orphans
michaelsutton Jun 29, 2022
08b6dc7
check if blocks exist
michaelsutton Jun 29, 2022
1bd560d
safe rpc mode
michaelsutton Jun 29, 2022
a1568d8
limit window size
michaelsutton Jun 29, 2022
f73bd51
verify block status depending on context
michaelsutton Jun 29, 2022
0b4151f
allow a 2 factor gap in expected mergeset size
michaelsutton Jun 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
continue also if orphans
  • Loading branch information
@michaelsutton
michaelsutton committed Jun 29, 2022
commit ea285755d44490e14df4fd7bef56cf2d482160df
14 changes: 9 additions & 5 deletions app/rpc/rpchandlers/get_mempool_entries_by_addresses.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ func HandleGetMempoolEntriesByAddresses(context *rpccontext.Context, _ *router.R
if getMempoolEntriesByAddressesRequest.IncludeOrphanPool {

orphanPoolTransactions := context.Domain.MiningManager().AllOrphanTransactions()
orphanPoolEntriesByAddresse, err := extractMempoolEntriesByAddressesFromTransactions(
orphanPoolEntriesByAddress, err := extractMempoolEntriesByAddressesFromTransactions(
context,
getMempoolEntriesByAddressesRequest.Addresses,
orphanPoolTransactions,
Expand All @@ -59,7 +59,7 @@ func HandleGetMempoolEntriesByAddresses(context *rpccontext.Context, _ *router.R
return errorMessage, nil
}

mempoolEntriesByAddresses = append(mempoolEntriesByAddresses, orphanPoolEntriesByAddresse...)
mempoolEntriesByAddresses = append(mempoolEntriesByAddresses, orphanPoolEntriesByAddress...)
}

return appmessage.NewGetMempoolEntriesByAddressesResponseMessage(mempoolEntriesByAddresses), nil
Expand All @@ -80,9 +80,13 @@ func extractMempoolEntriesByAddressesFromTransactions(context *rpccontext.Contex
for _, transaction := range transactions {

for i, input := range transaction.Inputs {
// TODO: Fix this
if input.UTXOEntry == nil && !areOrphans { //orphans can have `input.UTXOEntry == nil`, this is not a bug!
log.Debugf("Couldn't find UTXO entry for input %d in mempool transaction %s. This is a bug and should be fixed.", i, consensushashing.TransactionID(transaction))
if input.UTXOEntry == nil {
if !areOrphans { // Orphans can legitimately have `input.UTXOEntry == nil`
// TODO: Fix the underlying cause of the bug for non-orphan entries
log.Debugf(
"Couldn't find UTXO entry for input %d in mempool transaction %s. This is a bug and should be fixed.",
i, consensushashing.TransactionID(transaction))
}
continue
}

Expand Down