Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cosigner index 0 for read only wallets #2014

Merged

Conversation

someone235
Copy link
Collaborator

Fixes a problem with read only wallets where the addresses it generates belong to cosigner index -1 and are not scanned by the other wallets

@codecov
Copy link

codecov bot commented Apr 9, 2022

Codecov Report

Merging #2014 (acceb19) into dev (6725902) will increase coverage by 0.06%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              dev    #2014      +/-   ##
==========================================
+ Coverage   59.65%   59.72%   +0.06%     
==========================================
  Files         663      663              
  Lines       31558    31560       +2     
==========================================
+ Hits        18827    18849      +22     
+ Misses      10044    10030      -14     
+ Partials     2687     2681       -6     
Impacted Files Coverage Δ
cmd/kaspawallet/create.go 0.00% <0.00%> (ø)
...k/netadapter/server/grpcserver/connection_loops.go 56.89% <0.00%> (-3.45%) ⬇️
infrastructure/network/netadapter/router/route.go 88.57% <0.00%> (+5.71%) ⬆️
...rver/grpcserver/protowire/rpc_get_mempool_entry.go 72.72% <0.00%> (+6.06%) ⬆️
infrastructure/network/rpcclient/rpcclient.go 69.66% <0.00%> (+6.74%) ⬆️
infrastructure/network/rpcclient/rpc_get_info.go 63.63% <0.00%> (+18.18%) ⬆️
...ructure/network/rpcclient/rpc_get_mempool_entry.go 63.63% <0.00%> (+18.18%) ⬆️
app/rpc/rpchandlers/get_mempool_entry.go 64.70% <0.00%> (+23.52%) ⬆️
...etadapter/server/grpcserver/protowire/rpc_error.go 100.00% <0.00%> (+25.00%) ⬆️
app/appmessage/error.go 27.27% <0.00%> (+27.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6725902...acceb19. Read the comment docs.

@someone235 someone235 merged commit 357e8ce into kaspanet:dev Apr 10, 2022
@someone235 someone235 deleted the use-cosigner-0-for-read-only-wallets branch April 10, 2022 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants