Reject out of date blocks submitted via RPC #1914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h are out of virtual DAA window)
Codecov Report
@@ Coverage Diff @@
## dev #1914 +/- ##
=======================================
Coverage 61.46% 61.47%
=======================================
Files 628 628
Lines 29556 29568 +12
=======================================
+ Hits 18167 18176 +9
- Misses 8814 8817 +3
Partials 2575 2575
Continue to review full report at Codecov.
|
michaelsutton
commented
Dec 28, 2021
infrastructure/config/config.go
Outdated
| @@ -122,6 +122,7 @@ type Flags struct { | |||
| IsArchivalNode bool `long:"archival" description:"Run as an archival node: don't delete old block data when moving the pruning point (Warning: heavy disk usage)'"` | |||
| AllowSubmitBlockWhenNotSynced bool `long:"allow-submit-block-when-not-synced" hidden:"true" description:"Allow the node to accept blocks from RPC while not synced (this flag is mainly used for testing)"` | |||
| EnableSanityCheckPruningUTXOSet bool `long:"enable-sanity-check-pruning-utxo" hidden:"true" description:"When moving the pruning point - check that the utxo set matches the utxo commitment"` | |||
| AllowSubmittingNonDAABlocks bool `long:"allow-non-daa-blocks" hidden:"false" description:"When submitting blocks via RPC - accept blocks which are out of virtual daa window (although such blocks are not rewarded anyhow)"` | |||
There was a problem hiding this comment.
@someone235 is hidden:"false" needed here ?
There was a problem hiding this comment.
I think it's better to move this flag directly to the submitBlock RPC command
someone235
requested changes
Dec 28, 2021
infrastructure/config/config.go
Outdated
| @@ -122,6 +122,7 @@ type Flags struct { | |||
| IsArchivalNode bool `long:"archival" description:"Run as an archival node: don't delete old block data when moving the pruning point (Warning: heavy disk usage)'"` | |||
| AllowSubmitBlockWhenNotSynced bool `long:"allow-submit-block-when-not-synced" hidden:"true" description:"Allow the node to accept blocks from RPC while not synced (this flag is mainly used for testing)"` | |||
| EnableSanityCheckPruningUTXOSet bool `long:"enable-sanity-check-pruning-utxo" hidden:"true" description:"When moving the pruning point - check that the utxo set matches the utxo commitment"` | |||
| AllowSubmittingNonDAABlocks bool `long:"allow-non-daa-blocks" hidden:"false" description:"When submitting blocks via RPC - accept blocks which are out of virtual daa window (although such blocks are not rewarded anyhow)"` | |||
There was a problem hiding this comment.
I think it's better to move this flag directly to the submitBlock RPC command
svarogg
approved these changes
Dec 29, 2021
someone235
approved these changes
Dec 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to avoid lagging miners from spamming the network, we reject by default all submitted blocks with
DAA score < virtual DAA score - DAA window size. Such blocks are not rewarded anyhow. See issue #1896