Changes to libkaspawallet to support Kaspaper #1878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
someone235
requested changes
Dec 11, 2021
cmd/kaspawallet/keys/keys.go
Outdated
| @@ -89,6 +90,22 @@ func (d *File) toJSON() *keysFileJSON { | |||
| } | |||
| } | |||
|
|
|||
| func NewFileFromMnemonics(params *dagconfig.Params, mnemonics string, password string) (*File, error) { | |||
There was a problem hiding this comment.
Please change mnemonics to mnemonic
svarogg
force-pushed
the
support-kaspaper
branch
from
e6ead44 to
9e6dcfd
Compare
Codecov Report
@@ Coverage Diff @@
## dev #1878 +/- ##
==========================================
- Coverage 61.74% 61.68% -0.06%
==========================================
Files 624 624
Lines 29397 29410 +13
==========================================
- Hits 18150 18143 -7
- Misses 8673 8691 +18
- Partials 2574 2576 +2
Continue to review full report at Codecov.
|
someone235
approved these changes
Dec 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.