Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PruningPointProof to the P2P protocol #1825

Merged
merged 15 commits into from
Sep 5, 2021

Conversation

stasatdaglabs
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Sep 5, 2021

Codecov Report

Merging #1825 (984aad7) into v0.11.0-dev (02a0890) will decrease coverage by 0.02%.
The diff coverage is 59.29%.

Impacted file tree graph

@@               Coverage Diff               @@
##           v0.11.0-dev    #1825      +/-   ##
===============================================
- Coverage        62.05%   62.02%   -0.03%     
===============================================
  Files              620      625       +5     
  Lines            28272    28382     +110     
===============================================
+ Hits             17543    17605      +62     
- Misses            8276     8308      +32     
- Partials          2453     2469      +16     
Impacted Files Coverage Δ
app/appmessage/message.go 71.42% <ø> (ø)
app/appmessage/p2p_msgpruningpoints.go 100.00% <ø> (ø)
...er/grpcserver/protowire/p2p_pruning_point_proof.go 35.71% <35.71%> (ø)
app/appmessage/p2p_msgpruningpointproof.go 40.00% <40.00%> (ø)
app/appmessage/domainconverters.go 87.26% <50.00%> (-1.69%) ⬇️
...rotocol/flows/blockrelay/ibd_with_headers_proof.go 44.21% <53.33%> (-0.18%) ⬇️
...erver/protowire/p2p_request_pruning_point_proof.go 66.66% <66.66%> (ø)
...ork/netadapter/server/grpcserver/protowire/wire.go 46.15% <66.66%> (+0.35%) ⬆️
.../blockrelay/handle_pruning_point_proof_requests.go 71.42% <71.42%> (ø)
app/appmessage/p2p_msgrequestpruningpointproof.go 100.00% <100.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02a0890...984aad7. Read the comment docs.

func (s *consensus) BuildPruningPointProof() (*externalapi.PruningPointProof, error) {
s.lock.Lock()
defer s.lock.Unlock()

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a TODO?

func (s *consensus) ValidatePruningPointProof(pruningPointProof *externalapi.PruningPointProof) error {
s.lock.Lock()
defer s.lock.Unlock()

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a TODO?


// PruningPointProof is the data structure holding the pruning point proof
type PruningPointProof struct {
Headers []BlockHeader
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be two dimensional

@someone235 someone235 merged commit af7e7de into kaspanet:v0.11.0-dev Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants