-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PruningPointProof to the P2P protocol #1825
Add PruningPointProof to the P2P protocol #1825
Conversation
Codecov Report
@@ Coverage Diff @@
## v0.11.0-dev #1825 +/- ##
===============================================
- Coverage 62.05% 62.02% -0.03%
===============================================
Files 620 625 +5
Lines 28272 28382 +110
===============================================
+ Hits 17543 17605 +62
- Misses 8276 8308 +32
- Partials 2453 2469 +16
Continue to review full report at Codecov.
|
func (s *consensus) BuildPruningPointProof() (*externalapi.PruningPointProof, error) { | ||
s.lock.Lock() | ||
defer s.lock.Unlock() | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a TODO?
func (s *consensus) ValidatePruningPointProof(pruningPointProof *externalapi.PruningPointProof) error { | ||
s.lock.Lock() | ||
defer s.lock.Unlock() | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a TODO?
|
||
// PruningPointProof is the data structure holding the pruning point proof | ||
type PruningPointProof struct { | ||
Headers []BlockHeader |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be two dimensional
No description provided.