Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Friendly error messages for ban and unban with ip with brackets #1762

Merged
merged 1 commit into from
Jun 21, 2021

Conversation

constantineatdaglabs
Copy link
Contributor

Fixes #1712

@codecov
Copy link

codecov bot commented Jun 20, 2021

Codecov Report

Merging #1762 (dd383be) into v0.11.0-dev (bdd4290) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head dd383be differs from pull request most recent head b4b5266. Consider uploading reports for the commit b4b5266 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           v0.11.0-dev    #1762      +/-   ##
===============================================
- Coverage        58.72%   58.71%   -0.02%     
===============================================
  Files              584      584              
  Lines            23098    23104       +6     
===============================================
+ Hits             13564    13565       +1     
- Misses            7353     7359       +6     
+ Partials          2181     2180       -1     
Impacted Files Coverage Δ
app/rpc/rpchandlers/ban.go 0.00% <0.00%> (ø)
app/rpc/rpchandlers/unban.go 0.00% <0.00%> (ø)
...ain/consensus/database/binaryserialization/hash.go 64.70% <0.00%> (-5.89%) ⬇️
...selectedchainstore/headers_selected_chain_store.go 67.12% <0.00%> (ø)
infrastructure/network/addressmanager/store.go 76.98% <0.00%> (+1.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdd4290...b4b5266. Read the comment docs.

app/rpc/rpchandlers/ban.go Show resolved Hide resolved
app/rpc/rpchandlers/unban.go Show resolved Hide resolved
@someone235 someone235 merged commit 319cbce into kaspanet:v0.11.0-dev Jun 21, 2021
@constantineatdaglabs constantineatdaglabs deleted the parseip branch June 21, 2021 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants