Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write in the reject message the tx rejection reason #1573

Merged
merged 3 commits into from
Mar 2, 2021

Conversation

someone235
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Mar 2, 2021

Codecov Report

Merging #1573 (793251c) into v0.9.0-dev (7829a9f) will decrease coverage by 0.09%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff               @@
##           v0.9.0-dev    #1573      +/-   ##
==============================================
- Coverage       60.15%   60.05%   -0.10%     
==============================================
  Files             515      515              
  Lines           20290    20290              
==============================================
- Hits            12206    12186      -20     
- Misses           6151     6176      +25     
+ Partials         1933     1928       -5     
Impacted Files Coverage Δ
...ws/transactionrelay/handle_relayed_transactions.go 48.35% <0.00%> (ø)
...consensus/database/serialization/acceptancedata.go 41.46% <0.00%> (-36.59%) ⬇️
...uctures/acceptancedatastore/acceptancedatastore.go 48.88% <0.00%> (-15.56%) ⬇️
app/protocol/flows/blockrelay/handle_relay_invs.go 70.00% <0.00%> (+1.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7829a9f...833b812. Read the comment docs.

@elichai elichai merged commit 18274c2 into v0.9.0-dev Mar 2, 2021
@elichai elichai deleted the write-tx-reject-reason branch March 2, 2021 18:15
@elichai elichai linked an issue Mar 3, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Print reject reason to log when a transaction is rejected
2 participants