Don't mark block that got rejected because of ruleerrors.ErrPrunedBlock as invalid #1529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## v0.9.0-dev #1529 +/- ##
==============================================
+ Coverage 61.80% 61.82% +0.01%
==============================================
Files 507 507
Lines 19238 19247 +9
==============================================
+ Hits 11890 11899 +9
- Misses 5642 5643 +1
+ Partials 1706 1705 -1
Continue to review full report at Codecov.
|
svarogg
requested changes
Feb 15, 2021
| @@ -54,11 +54,14 @@ func (bp *blockProcessor) validateBlock(block *externalapi.DomainBlock, isPrunin | |||
| if err != nil { | |||
| if errors.As(err, &ruleerrors.RuleError{}) { | |||
| // If we got ErrMissingParents the block shouldn't be considered as invalid | |||
| // because it could be added later on when its parents are present, and if | |||
There was a problem hiding this comment.
I'd reformat this comment as something like:
We don't mark the following errors as invalid for the following reasons:
ErrMissingParents - explanation
ErrBlabla - explanation
etc.
svarogg
approved these changes
Feb 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If someone sends you a pruned block you reject the block, but the header is still valid