Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: collect to list (non-windowed) (primitive/strings/booleans) #569

Merged
merged 13 commits into from
Jul 31, 2023
Merged

feat: collect to list (non-windowed) (primitive/strings/booleans) #569

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
db21e39
add skeleton evaluator
jordanrfrazier Jul 28, 2023
d950c4f
add primitive collect evaluator
jordanrfrazier Jul 29, 2023
68229b0
Add unit tests
jordanrfrazier Jul 29, 2023
54d4afe
update e2e tests
jordanrfrazier Jul 29, 2023
dd3140e
cleanup evaluators
jordanrfrazier Jul 29, 2023
9af194e
clippy
jordanrfrazier Jul 29, 2023
c4d8e1d
Add state token
jordanrfrazier Jul 31, 2023
5bdcbfa
Allow to indicate unlimited size
jordanrfrazier Jul 31, 2023
2400de5
golang proto incorrect type
jordanrfrazier Jul 31, 2023
68c3a2a
updated tests
kevinjnguyen Jul 31, 2023
4e340b9
use copied instead of clone for values
jordanrfrazier Jul 31, 2023
5622d0b
remove integ tests changes
jordanrfrazier Jul 31, 2023
24ba56e
use cloned for strings
jordanrfrazier Jul 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
use cloned for strings
  • Loading branch information
@jordanrfrazier
jordanrfrazier committed Jul 31, 2023
commit 24ba56ea02dfc9f89a7dadbb5556d3ceb479d14f
2 changes: 1 addition & 1 deletion crates/sparrow-instructions/src/evaluators/list/collect_string.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ impl CollectStringEvaluator {
.add_value(self.max, entity_index, input.map(|s| s.to_owned()));
let cur_list = self.token.state(entity_index);

list_builder.append_value(cur_list.iter().copied());
list_builder.append_value(cur_list.clone());
});

Ok(Arc::new(list_builder.finish()))
Expand Down