Skip to content

Commit

Permalink
[CMake] Remove BUILDING_WITH_TORCH_LIBS (pytorch#134434)
Browse files Browse the repository at this point in the history
Since BUILDING_WITH_TORCH_LIBS is not used now.

Pull Request resolved: pytorch#134434
Approved by: https://github.com/ezyang
  • Loading branch information
cyyever authored and pytorchmergebot committed Aug 27, 2024
1 parent bdfc1d3 commit 2ee201a
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 9 deletions.
4 changes: 0 additions & 4 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -490,10 +490,6 @@ if(USE_SYSTEM_LIBS)
endif()
endif()

# Used when building Caffe2 through setup.py
option(BUILDING_WITH_TORCH_LIBS
"Tell cmake if Caffe2 is being built alongside torch libs" ON)

# /Z7 override option When generating debug symbols, CMake default to use the
# flag /Zi. However, it is not compatible with sccache. So we rewrite it off.
# But some users don't use sccache; this override is for them.
Expand Down
4 changes: 0 additions & 4 deletions scripts/build_windows.bat
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,6 @@ if NOT DEFINED BUILD_SHARED_LIBS (
)
)

IF NOT DEFINED BUILDING_WITH_TORCH_LIBS (
set BUILDING_WITH_TORCH_LIBS=OFF
)

if NOT DEFINED CAFFE2_STATIC_LINK_CUDA (
set CAFFE2_STATIC_LINK_CUDA=OFF
)
Expand Down
1 change: 0 additions & 1 deletion tools/setup_helpers/cmake.py
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,6 @@ def generate(
"UBSAN_FLAGS",
"BLAS",
"WITH_BLAS",
"BUILDING_WITH_TORCH_LIBS",
"CUDA_HOST_COMPILER",
"CUDA_NVCC_EXECUTABLE",
"CUDA_SEPARABLE_COMPILATION",
Expand Down

0 comments on commit 2ee201a

Please sign in to comment.