-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transparent windows, optional decorations #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Visually functional but crude; close button works.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support transparent windows. Bug: output may expect pre-multiplied alpha; we do not output that. Not trivial to handle since WGPU enumerates several modes but not all are supported, so possibly we should support both pre- and non-pre-multiplied alpha output?
Support multiple window decoration modes: none, frame-only, frame+titlebar (toolkit drawn), server-side. Limitation: winit does not currently support server-side decorations on Wayland.
New (very basic) graphics for toolkit-drawn titlebar (currently lacking support for an icon). Need to decide what image formats we support for this; use
Image
widget or justVec<u8>
like Winit. Limitation: theTitleBar
widget is defined in KAS-core thus cannot use KAS-widgets's widgets. At least, this is the current state.Adjust
examples/clock.rs
to be transparent:New, enabled-by-default features:
wayland
,x11
. Do not usewinit/wayland-csd-adwaita
thus reducing dependencies. Size ofgallery
(release, stripped): previously 18M, now 17M, down as low as 11M (minimal features only on X11, which still includes WGPU and resvg).