Move contents of kas-theme to kas-core, kas-wgpu #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This required making some fields of SimpleTheme public to support ShadedTheme. The theme extension/inheritence needs mechanism needs to be reviewed.
This theme uses special WGPU shaders, hence it makes sense that it live here (unless/until another graphics backend supports it; not too likely since it isn't a popular theme).
We don't have a reason to make theme components optional.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Theme traits need to be moved to kas-core for the next PR, which moves the shell and winit components to kas-core (which is needed for the next PR, async work).
This PR moves most of kas-theme to kas-core, but moves the "Shaded Theme" and accompanying draw extensions to kas-wgpu (since these extensions are unlikely to be implemented for any other graphics backend, due both to the use of specific shaders and the low popularity of the theme).