Skip to content

Conversation

cuviper
Copy link
Contributor

@cuviper cuviper commented Aug 9, 2023

This is only needed for impl From<syn::Error> for Diagnostic, which is
irrelevant when impl-tools is using syn v2.

This is only needed for `impl From<syn::Error> for Diagnostic`, which is
irrelevant when impl-tools is using syn v2.
@dhardy
Copy link
Contributor

dhardy commented Aug 10, 2023

Thanks. I noticed proc-macro-error is pulling in syn v1 but missed that it can easily be avoided.

@dhardy dhardy merged commit e0c8012 into kas-gui:master Aug 10, 2023
@cuviper
Copy link
Contributor Author

cuviper commented Aug 10, 2023

Thanks for merging! Could we get a published release with this change?
(This is the last syn v1 connection I have in one of my personal projects.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants