Fix attachment link resolution with org-attach ID-based storage #1087
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1073
This PR fixes an issue where gptel does not correctly locate media files referenced by org-mode "attachment" links when using org-attach's ID-based storage support.
Changes
1.
gptel-org.el
(gptel--parse-media-links)org-attach-expand
to properly resolve attachment-type links to their actual file pathsdeclare-function
fororg-attach-expand
2.
gptel-request.el
(gptel--realize-query)gptel--parse-buffer
in the original buffer context rather than the temp bufferorg-attach-expand
has access to Org properties (ID, ATTACH_DIR) needed to resolve attachment pathsTesting
Test plan
org-attach-id-dir
to a location outside the working directoryorg-attach
[[attachment:filename.png]]
Without this fix, the LLM would not receive the image. With the fix, the image is properly encoded and included in the request.
🤖 Generated with Claude Code