Quasar 2 - second try

[tiltec]

Branch deployment URL: https://quasar-2-second-try.dev.karrot.world/

To do before merging

• get login & activity signup to work on production build

Further notes

- [ ] fix map on place pages

check if qselect still works: ActivityList, ActivitySeriesEdit, ActivityFeedback, ActivityTypeForm, AddressPicker, PlaceEdit, ActivityHistoryStatistics

switch language button: missing space after icon

qroutetab editlayout deprecation?

fix storybook:
- remove props object
- import h from vue
- add 'on' to click handler names
- add 'emit' property in vue component (if emitted from component)

amoutviewer correct?

groupedit application message is too specific for group create

new sentry format: https://docs.sentry.io/platforms/javascript/guides/vue/#vue-3

vue router app.use()?

enable stylelint again?

i18n export: .global?

i18n: en-US seems default locale?

fix router scroll behavior: selector: to.hash https://github.com/vuejs/rfcs/blob/master/active-rfcs/0035-router-scroll-position.md

router exact option is deprecated

remove vuex-router-sync? `router.currentRoute.value`

fix tests (majestic!)
- vue/compat conflicts with installQuasarPlugin
- can't do jest.resetModules() with vue-router and vue-i18n

production build?

cordova?

object.freeze still works?

failed email deliveries: no detail message

lolex -> https://github.com/sinonjs/fake-timers/blob/main/CHANGELOG.md

Closes #2350

[github-actions]

This pull request is marked as stale because it has not had any activity for 90 days.

It doesn't mean it's not important, so please remove the stale label if you like it, or add a comment saying what it means to you :)

However, if you just leave it like this, I'll close it in 7 days to help keep your pull requests tidy!

Thanks!

[nicksellen]

Woo! That was quite some work 🙏

Looks like a mix of a lot of fiddly chore work, then interspersed with important changes... and a lot of checking if stuff actually works 🚀

I approved, just to get that bit out the way, and leave you to decide which of my comments make sense to do anything about. Then, I'll be up for working together to fix any shit left over after merging!

[tiltec]

Just found out that vue-i18n v9 added one unfortunate special characters to their message syntax: @

https://vue-i18n.intlify.dev/guide/essentials/syntax.html#special-characterssomenb

At least the Spanish locale is using @ for some reason, but generally we would need to find some way to tell our translators that they can't use @ literally...

[codecov]

Codecov Report

Merging #2438 (2061076) into master (09a73c0) will decrease coverage by 3.84%.
The diff coverage is 80.06%.

@@            Coverage Diff             @@
##           master    #2438      +/-   ##
==========================================
- Coverage   56.83%   52.99%   -3.85%     
==========================================
  Files         289      180     -109     
  Lines        5947     4863    -1084     
  Branches      987      817     -170     
==========================================
- Hits         3380     2577     -803     
+ Misses       2565     2286     -279     
+ Partials        2        0       -2     

Impacted Files	Coverage Δ
src/activities/components/ActivityList.vue	100.00% <ø> (+11.11%)	⬆️
src/activities/components/EmptySlot.vue	100.00% <ø> (ø)
src/authuser/datastore/deleteAccount.js	29.41% <0.00%> (ø)
src/authuser/datastore/verifymail.js	14.28% <0.00%> (ø)
src/base/datastore/i18nPlugin.js	0.00% <0.00%> (ø)
src/locales/index.js	7.86% <0.00%> (ø)
src/maps/components/AddressPicker.story.js	100.00% <ø> (ø)
src/maps/components/GroupMap.vue	100.00% <ø> (+26.66%)	⬆️
src/maps/components/PlaceMarker.vue	50.00% <0.00%> (-50.00%)	⬇️
src/maps/components/markers.js	100.00% <ø> (ø)
... and 208 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09a73c0...2061076. Read the comment docs.