Conversation
ngc92
force-pushed
the
ngc92/llama3-cudnn
branch
10 times, most recently
from
e616e00 to
c157bc7
Compare
ngc92
force-pushed
the
ngc92/llama3-cudnn
branch
from
c157bc7 to
cbe9007
Compare
ngc92
force-pushed
the
ngc92/llama3-cudnn
branch
4 times, most recently
from
7556f7a to
eceab69
Compare
ngc92
force-pushed
the
ngc92/llama3-cudnn
branch
from
eceab69 to
90a409c
Compare
ngc92
force-pushed
the
ngc92/llama3-cudnn
branch
from
90a409c to
9f05d7b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds a cudnn implementation that allows for GQA
for better compatibility, that means that our rope kernel needs to be GQA aware, too, then we can just exchange the order of rope and repkv and reuse most of the code between the cudnn/non-cudnn code-paths.