Give better error message in Tinystories data loader #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RahulSChand
changed the title
madroidmaq
suggested changes
Aug 19, 2023
There was a problem hiding this comment.
Great tip, I just ran into this problem. I suggest that you can prompt the copy under optimization. When you really encounter this problem, you can provide some tips for checking errors. like:
"No bin files found in {bin_dir}, Please check the pretokenize execution result."
|
thank you for the PR, good add |
vinhtran2611
pushed a commit
to vinhtran2611/llama2.c
that referenced
this pull request
Jan 20, 2024
Give better error message in Tinystories data loader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are few open issues of people getting stuck running
train.pybecausetinystories.pydata loader will be stuck in an infinite loop if there are no .bin files in the data directory. Have added an assert statement so that there is a more informative error message rather than training just being stuck.Relevant issues
#296
#311