Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed generic error message when input.txt can't be found #125

Merged
merged 1 commit into from
Oct 26, 2015
Merged

Fixed generic error message when input.txt can't be found #125

merged 1 commit into from
Oct 26, 2015

Conversation

skwerlman
Copy link
Contributor

I simply added an assert around the io.open which grabs input.txt. Now, instead of:

./util/CharSplitLMMinibatchLoader.lua:139: attempt to index global 'f' (a nil value)

the user sees something similar to:

./util/CharSplitLMMinibatchLoader.lua:133: data/tinyshakespeare/input.txt: No such file or directory

I also fixed f being global.

@skwerlman
Fix unclear errors
b3c7e3c 
also fixed accidental global
karpathy added a commit that referenced this pull request Oct 26, 2015
@karpathy
Merge pull request #125 from skwerlman/master
106a75c 
Fixed generic error message when input.txt can't be found
@karpathy karpathy merged commit 106a75c into karpathy:master Oct 26, 2015
@karpathy
Copy link
Owner

Looks great, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skwerlman @karpathy