forked from mesonbuild/meson
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
minstall: rework root elevation prompt for extensibility and behavior
There's a couple issues with the current approach: - pkexec is an unusual elevation method, the standard is sudo - it tries to elevate even in automated workflows - the user may not want to automatically rerun as root, that might be badly behaved Do some upfront checks instead, first to make sure it even makes sense to try becoming root, and then to ask the user "do you really want this". Also check for a couple common approaches to root elevation, including doas. Fixes mesonbuild#7345 Fixes mesonbuild#7809
- Loading branch information
Eli Schwartz
committed
Feb 21, 2023
1 parent
7884149
commit a878c38
Showing
3 changed files
with
39 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
## `meson install` now supports user-preferred root elevation tools | ||
|
||
Previously, when installing a project, if any files could not be installed due | ||
to insufficient permissions the install process was automatically re-run using | ||
polkit. Now it prompts to ask whether that is desirable, and checks for | ||
CLI-based tools such as sudo or opendoas or `$MESON_ROOT_CMD`, first. | ||
|
||
Meson will no longer attempt privilege elevation at all, when not running | ||
interactively. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters