Fixed compilation instructions #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you so much, John! We will try to replace the code. Best wishes, Karolina |
karolamik13
pushed a commit
that referenced
this pull request
Oct 6, 2023
Support for bonds, test cases, other fixes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Karolina,
This PR partially fixes the compilation of the new module. However, the fortran module that the code is still an issue. Most machines won't have gfortran to compile it, nor should we expect the users to install it, for several reasons: 1) it needs to be installed by apt-get or homebrew, not pip; 2) not sure if it can be compiled correctly on all platforms (Mac & Windows); 3) unmaintainable code (we should think about replacing the C/C++ modules with Cython or Python code for that matter). Any chance they could depend on a another library that is not written by fortran?
Best,
John