Repository navigation
docs - fixed configuration file priority over CLI flags in karmadactl… - #1037
apoorvslst wants to merge 1 commit into
Conversation
karmada-bot
added
the
kind/documentation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Welcome @apoorvslst! It looks like this is your first PR to karmada-io/website 🎉 |
karmada-bot
added
the
size/M
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates several versions of the karmadactl-config.v1alpha1.md documentation to clarify that configuration file values take precedence over command-line flags. The reviewer noted that the example configuration path used, apiServer.replicas, is incorrect and should be updated to components.karmadaAPIServer.replicas to prevent user confusion.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
f5294e2 to
af65c47
Compare
…init Signed-off-by: apoorvslst <apoorvarceus13012007@gmail.com>
06925e0 to
1861ccb
Compare
2 participants
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Fixes a doc error for
karmadactl init. The docs used to say that CLI flags override the config file, but it's actually the other way around (the config file wins). This updates the docs to match the actual code behavior and the original design proposal.Which issue(s) this PR fixes:
Fixes #925
Special notes for your reviewer:
(You can just leave this blank or delete this line)