Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add version command to components #719

Merged

Conversation

lonelyCZ
Copy link
Member

What type of PR is this?
/kind feature

What this PR does / why we need it:

$ ./karmada-scheduler version
karmada-scheduler version: version.Info{GitVersion:"v0.8.0-106-gb2b36a2-dirty", GitCommit:"b2b36a2aaf9038684e96a6c56c1589dbb43bef37", GitTreeState:"dirty", BuildDate:"2021-09-13T03:13:33Z", GoVersion:"go1.16.7", Compiler:"gc", Platform:"linux/amd64"}
$ ./karmada-webhook version
karmada-webhook version: version.Info{GitVersion:"v0.8.0-106-gb2b36a2-dirty", GitCommit:"b2b36a2aaf9038684e96a6c56c1589dbb43bef37", GitTreeState:"dirty", BuildDate:"2021-09-13T03:13:33Z", GoVersion:"go1.16.7", Compiler:"gc", Platform:"linux/amd64"}
$ ./karmada-agent version
karmada-agent version: version.Info{GitVersion:"v0.8.0-106-gb2b36a2-dirty", GitCommit:"b2b36a2aaf9038684e96a6c56c1589dbb43bef37", GitTreeState:"dirty", BuildDate:"2021-09-13T03:13:33Z", GoVersion:"go1.16.7", Compiler:"gc", Platform:"linux/amd64"}
$ ./karmada-scheduler-estimator version
karmada-scheduler-estimator version: version.Info{GitVersion:"v0.8.0-106-gb2b36a2-dirty", GitCommit:"b2b36a2aaf9038684e96a6c56c1589dbb43bef37", GitTreeState:"dirty", BuildDate:"2021-09-13T03:13:33Z", GoVersion:"go1.16.7", Compiler:"gc", Platform:"linux/amd64"}

Which issue(s) this PR fixes:
Fixes #716

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`karmada-scheduler` introduced a `version` command to represent version information.
`karmada-webhook` introduced a `version` command to represent version information.
`karmada-agent` introduced a `version` command to represent version information.
`karmada-scheduler-estimator` introduced a `version` command to represent version information.

@karmada-bot karmada-bot added kind/feature Categorizes issue or PR as related to a new feature. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 13, 2021
@lonelyCZ lonelyCZ force-pushed the lonelyCZ-components-version-command branch from e20250d to 6cc4574 Compare September 13, 2021 03:49
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
But you might need to fix the lint issue.

@lonelyCZ lonelyCZ force-pushed the lonelyCZ-components-version-command branch 2 times, most recently from 742dd12 to 3cb0b34 Compare September 13, 2021 09:22
Signed-off-by: lonelyCZ <531187475@qq.com>
@lonelyCZ lonelyCZ force-pushed the lonelyCZ-components-version-command branch from 3cb0b34 to ae9f7bd Compare September 13, 2021 09:23
@lonelyCZ
Copy link
Member Author

Hi, @RainbowMango
the lint issue should be fixed, please review it again.

@RainbowMango
Copy link
Member

/lgtm
/approve
Thanks~

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2021
@RainbowMango RainbowMango added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2021
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot merged commit 0c8a020 into karmada-io:master Sep 14, 2021
@lonelyCZ lonelyCZ deleted the lonelyCZ-components-version-command branch November 30, 2021 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce version command to karmada components
3 participants