-
Notifications
You must be signed in to change notification settings - Fork 883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support unregister cluster in karmada #5626
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5626 +/- ##
==========================================
+ Coverage 40.85% 41.52% +0.67%
==========================================
Files 651 655 +4
Lines 55259 55647 +388
==========================================
+ Hits 22577 23110 +533
+ Misses 31240 31038 -202
- Partials 1442 1499 +57
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
2c83a0f
to
f223e1b
Compare
f223e1b
to
d654302
Compare
According to what we communicated offline, pr is updated @chaosi-zju ready to review |
d654302
to
97fdd94
Compare
/lgtm /cc @zhzhuang-zju @RainbowMango help a look |
@chaosi-zju: GitHub didn't allow me to request PR reviews from the following users: a, look. Note that only karmada-io members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
97fdd94
to
cdfe48a
Compare
New changes are detected. LGTM label has been removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/assign
cdfe48a
to
aceb076
Compare
Signed-off-by: wulemao <1194736083@qq.com>
aceb076
to
d3654a1
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
support unregister cluster in karmada
Which issue(s) this PR fixes:
Fixes part of #5380
Special notes for your reviewer:
Does this PR introduce a user-facing change?: