Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support unregister cluster in karmada #5626

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wulemao
Copy link
Contributor

@wulemao wulemao commented Sep 30, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

support unregister cluster in karmada

Which issue(s) this PR fixes:

Fixes part of #5380

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

karmadactl: support unregister a pull mode cluster

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 30, 2024
@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 30, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 201 lines in your changes missing coverage. Please review.

Project coverage is 41.52%. Comparing base (e204459) to head (d3654a1).
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
pkg/karmadactl/unregister/unregister.go 0.00% 156 Missing ⚠️
pkg/karmadactl/util/cluster.go 0.00% 28 Missing ⚠️
pkg/karmadactl/register/register.go 0.00% 9 Missing ⚠️
pkg/util/secret.go 0.00% 6 Missing ⚠️
pkg/karmadactl/karmadactl.go 0.00% 1 Missing ⚠️
pkg/karmadactl/unjoin/unjoin.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5626      +/-   ##
==========================================
+ Coverage   40.85%   41.52%   +0.67%     
==========================================
  Files         651      655       +4     
  Lines       55259    55647     +388     
==========================================
+ Hits        22577    23110     +533     
+ Misses      31240    31038     -202     
- Partials     1442     1499      +57     
Flag Coverage Δ
unittests 41.52% <0.00%> (+0.67%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wulemao
Copy link
Contributor Author

wulemao commented Oct 24, 2024

latest test report:

图片

@wulemao
Copy link
Contributor Author

wulemao commented Oct 24, 2024

According to what we communicated offline, pr is updated

@chaosi-zju ready to review

@chaosi-zju
Copy link
Member

/lgtm

/cc @zhzhuang-zju @RainbowMango help a look

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2024
@karmada-bot
Copy link
Collaborator

@chaosi-zju: GitHub didn't allow me to request PR reviews from the following users: a, look.

Note that only karmada-io members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/lgtm

/cc @zhzhuang-zju @RainbowMango help a look

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@karmada-bot karmada-bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2024
@karmada-bot
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign

Signed-off-by: wulemao <1194736083@qq.com>
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from rainbowmango. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wulemao
Copy link
Contributor Author

wulemao commented Oct 26, 2024

updated, latest test result:

图片

is there any more comments?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants