-
Notifications
You must be signed in to change notification settings - Fork 883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved test coverage for policy in pkg/detector #5409
Conversation
Signed-off-by: Nishant Bansal <nishant.bansal.282003@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5409 +/- ##
==========================================
+ Coverage 29.82% 29.98% +0.15%
==========================================
Files 632 632
Lines 43936 43936
==========================================
+ Hits 13104 13173 +69
+ Misses 29874 29804 -70
- Partials 958 959 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hey @XiShanYongYe-Chang, I didn't provide complete coverage as the PR was getting large and to make it easier for you to review. I will add more tests once these changes are reviewed. |
Maybe you can split the pr and test it by file. |
Yeah, What I meant previously is that I have provided complete tests for |
Can you retest and review this PR. |
/retest |
Hey @XiShanYongYe-Chang, I was trying to write tests for - karmada/pkg/detector/policy.go Line 145 in 23cbfdc
ResourceDetector to fix the bugs. Could you point me to some resources where I can learn about ResourceDetector with examples?Thanks! |
This may involve code details. You can focus on the code of the detector. |
Hey @XiShanYongYe-Chang, I added some tests for other functions like - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks~
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
/kind failing-test
What this PR does / why we need it:
The test case coverage for pkg/detector/policy.go has been improved.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
To verify the changes in the pkg/detector/ directory run the following commands:
Does this PR introduce a user-facing change?: