Improved test coverage for policy in pkg/detector

[NishantBansal2003]

What type of PR is this?
/kind feature
/kind failing-test

What this PR does / why we need it:
The test case coverage for pkg/detector/policy.go has been improved.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
To verify the changes in the pkg/detector/ directory run the following commands:

go test ./... -coverprofile=coverage.out
go tool cover -html=coverage.out -o coverage.html
open coverage.html

Does this PR introduce a user-facing change?:

NONE

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.98%. Comparing base (d4bfbb5) to head (87da9a9).
Report is 2 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5409      +/-   ##
==========================================
+ Coverage   29.82%   29.98%   +0.15%     
==========================================
  Files         632      632              
  Lines       43936    43936              
==========================================
+ Hits        13104    13173      +69     
+ Misses      29874    29804      -70     
- Partials      958      959       +1     

Flag	Coverage Δ
unittests	29.98% <ø> (+0.15%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[NishantBansal2003]

Hey @XiShanYongYe-Chang, I didn't provide complete coverage as the PR was getting large and to make it easier for you to review. I will add more tests once these changes are reviewed.

[XiShanYongYe-Chang]

Hey @XiShanYongYe-Chang, I didn't provide complete coverage as the PR was getting large and to make it easier for you to review. I will add more tests once these changes are reviewed.

Maybe you can split the pr and test it by file.

[NishantBansal2003]

Maybe you can split the pr and test it by file.

Yeah, What I meant previously is that I have provided complete tests for removeResourceMarksIfNotMatched, listPPDerivedRBs, listCPPDerivedRBs, listCPPDerivedCRBs, and excludeClusterPolicy in policy.go. I will add tests for the other functions once these changes are reviewed(in other pr).

[NishantBansal2003]

Can you retest and review this PR.
cc: @XiShanYongYe-Chang

[XiShanYongYe-Chang]

/retest
/assign

[NishantBansal2003]

Hey @XiShanYongYe-Chang, I was trying to write tests for -

karmada/pkg/detector/policy.go

Line 145 in 23cbfdc

func (d *ResourceDetector) getAndApplyClusterPolicy(object *unstructured.Unstructured, objectKey keys.ClusterWideKey,

but I ran into some errors. I think I need to understand more about ResourceDetector to fix the bugs. Could you point me to some resources where I can learn about ResourceDetector with examples?
Thanks!

[XiShanYongYe-Chang]

but I ran into some errors. I think I need to understand more about ResourceDetector to fix the bugs. Could you point me to some resources where I can learn about ResourceDetector with examples?

This may involve code details. You can focus on the code of the detector.

[NishantBansal2003]

Hey @XiShanYongYe-Chang, I added some tests for other functions like - cleanPPUnmatchedRBs, cleanCPPUnmatchedRBs, cleanUnmatchedCRBs, removeRBsMarks and removeCRBsMarks. Should I push them in this commit, or should I wait for this PR to be merged and open another PR after that?

[XiShanYongYe-Chang]

Thanks~
/lgtm
/approve

[karmada-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [XiShanYongYe-Chang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment