Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin plural name for all APIs to avoid unexpected change #4778

Merged
merged 1 commit into from
Mar 30, 2024

Conversation

RainbowMango
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:
When the controller-tools generate the CRDs, it guesses the plural name by github.com/gobuffalo/flect if the plural name is not explicitly specified.

But the rule of generating plural names might change over different github.com/gobuffalo/flect versions. See kubernetes-sigs/controller-tools#804 (comment) for an example.

So, this PR pin plural name for all APIs to avoid this unexpected change.
(We don't depend on github.com/gobuffalo/flect, but the controller-tools reply on it. We might update controller-tools.)
Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

I'm trying to update the controller-tools but found the plural name of Karmada operator changed unexpectedly(see the fix at #4777), that reminds me we'd better pin the plural name.

Does this PR introduce a user-facing change?:

NONE

…dencies changes

Signed-off-by: RainbowMango <qdurenhongcai@gmail.com>
@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Mar 29, 2024
@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 29, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.78%. Comparing base (4e25482) to head (32a4076).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4778      +/-   ##
==========================================
- Coverage   51.78%   51.78%   -0.01%     
==========================================
  Files         250      250              
  Lines       24989    24989              
==========================================
- Hits        12941    12940       -1     
- Misses      11339    11340       +1     
  Partials      709      709              
Flag Coverage Δ
unittests 51.78% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot~
/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2024
@RainbowMango RainbowMango added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 30, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot merged commit 6534ffb into karmada-io:master Mar 30, 2024
13 checks passed
@RainbowMango RainbowMango deleted the pr_pin_crd_plural_name branch March 30, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants