Pin plural name for all APIs to avoid unexpected change #4778
+23
−19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
When the controller-tools generate the CRDs, it guesses the plural name by github.com/gobuffalo/flect if the plural name is not explicitly specified.
But the rule of generating plural names might change over different github.com/gobuffalo/flect versions. See kubernetes-sigs/controller-tools#804 (comment) for an example.
So, this PR pin plural name for all APIs to avoid this unexpected change.
(We don't depend on github.com/gobuffalo/flect, but the controller-tools reply on it. We might update controller-tools.)
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
I'm trying to update the controller-tools but found the plural name of Karmada operator changed unexpectedly(see the fix at #4777), that reminds me we'd better pin the plural name.
Does this PR introduce a user-facing change?: