Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] schedule workflow support workflow dispatch #4115

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[CI] schedule workflow support workflow dispatch #4115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/ci-schedule-compatibility.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
name: APIServer compatibility
on:
workflow_dispatch:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow_dispatch can trigger the workflow manually. Does that mean all developers can trigger the workflow at anytime?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have any concerns about this PR? If you don't want to be able to manually call these two workflows currently, then I think at least APIServer compatibility should not fail quickly,

Yes, it makes sense to me that let the scheduled workflow continue to run and avoid canceling due to other job failures.
But manually triggering the workflow is concerning.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kindly ping @liangyuanpeng

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @RainbowMango I have move the change of fail-fast: false to #4238 and there are fix a problem of timeout.

I want to keep this PR is open and i think let the workflow support workflow dispatch still relevant. Because I have done some exploration on combining this scheduled task with prow, I hope I will have an update on this aspect soon.

schedule:
# Run this workflow "At 20:00 UTC on Sunday and Saturday"
- cron: '0 20 * * 0,6'
Expand All @@ -11,6 +12,7 @@ jobs:
if: ${{ github.repository == 'karmada-io/karmada' }}
runs-on: ubuntu-22.04
strategy:
fail-fast: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

matrix:
kubeapiserver-version: [ v1.21.10, v1.22.7, v1.23.4, v1.24.2, v1.25.0, v1.26.0, v1.27.3 ]
karmada-version: [ release-1.4, release-1.5, release-1.6 ]
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/ci-schedule.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
name: CI Schedule Workflow
on:
workflow_dispatch:
schedule:
# Run this workflow "At 18:00 UTC on Sunday and Saturday"
- cron: '0 18 * * 0,6'
Expand Down
Loading