Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Merge pull request #3808 from ctripcloud/refactor-execution-workstatus" #4016

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

lxtywypc
Copy link
Contributor

This reverts commit 90ccbcd, reversing changes made to 24bb582.

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
As comment #3959 (comment)

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


…xecution-workstatus"

This reverts commit 90ccbcd, reversing
changes made to 24bb582.

Signed-off-by: lxtywypc <lxtywypc@gmail.com>
@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Aug 31, 2023
@karmada-bot karmada-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 31, 2023
@lxtywypc
Copy link
Contributor Author

@RainbowMango RainbowMango added this to the v1.7 milestone Aug 31, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 66.25% and project coverage change: +0.04% 🎉

Comparison is base (9003c83) 54.62% compared to head (67de65d) 54.66%.
Report is 2 commits behind head on master.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4016      +/-   ##
==========================================
+ Coverage   54.62%   54.66%   +0.04%     
==========================================
  Files         232      229       -3     
  Lines       22927    22492     -435     
==========================================
- Hits        12524    12296     -228     
+ Misses       9722     9540     -182     
+ Partials      681      656      -25     
Flag Coverage Δ
unittests 54.66% <66.25%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/controllers/context/context.go 48.57% <ø> (ø)
pkg/util/fedinformer/handlers.go 0.00% <0.00%> (ø)
pkg/controllers/status/work_status_controller.go 64.55% <75.18%> (+11.12%) ⬆️
pkg/util/lifted/objectwatcher.go 96.15% <83.33%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RainbowMango
Copy link
Member

/assign @XiShanYongYe-Chang @chaunceyjiang

@chaunceyjiang
Copy link
Member

/assign

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks~
LGTM

Copy link
Member

@chaunceyjiang chaunceyjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks~

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 31, 2023
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2023
@karmada-bot karmada-bot merged commit e78e86e into karmada-io:master Aug 31, 2023
11 checks passed
@lxtywypc lxtywypc deleted the revert-3808 branch November 14, 2023 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants