Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option way toget rest config of estimator schedule #3689

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ReOneK
Copy link

@ReOneK ReOneK commented Jun 21, 2023

Get rest config from aggregate apiserver if member cluster kubeconfig not provided.

What type of PR is this?

What this PR does / why we need it:
Get rest config from aggregate apiserver if member cluster kubeconfig not provided. Users may access the karmada control plane in different machine, some may not have member kubeconf exactly, and can also enable estimator across the control plane kubeconf, it's hard for user to manage all member cluster's kubeconf.

Which issue(s) this PR fixes:
Fixes #3687

Special notes for your reviewer:
NONE

Does this PR introduce a user-facing change?:

NONE

Get rest config from aggregate apiserver if member cluster
kubeconfig not provided.

Signed-off-by: ReOneK <959512421@qq.com>
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign garrybest after the PR has been reviewed.
You can assign the PR to them by writing /assign @garrybest in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot
Copy link
Collaborator

Welcome @ReOneK! It looks like this is your first PR to karmada-io/karmada 🎉

@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 21, 2023
Copy link
Member

@whitewindmills whitewindmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you show your use case?

@ReOneK
Copy link
Author

ReOneK commented Jun 21, 2023

Could you show your use case?

In my use case,users may access the karmada control plane in different machine, some may not have member kubeconf exactly, and can also enable estimator across the control plane kubeconf, it's hard for user to manage all member cluster's kubeconf.
On the other hand, mounting kubeconfig explicitly is not secure in my case.It also doesn't make sense to provide kubeconfig after the cluster has been joined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a compatible way to deploy karmada-scheduler-estimator
3 participants