-
Notifications
You must be signed in to change notification settings - Fork 883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ClusterWideKeyFunc don't get runtime.Object GVK #3275
Comments
@xigang Could you tell me what are you doing with the |
I don't know why you run this demo.
I guess you can print the objectKey before marshall it. |
Updated the test code to change GetClusterWideKey to ClusterWideKeyFunc https://github.com/karmada-io/karmada/blob/master/pkg/util/fedinformer/keys/keys.go#L63 |
@RainbowMango The GVK will returned is null from the ClusterWideKeyFunc L77 line code.
|
Where is the |
It has nothing to do with karmada because |
@whitewindmills Yes, but this ClusterWideKeyFunc needs to handle scenarios where GVK is empty? eg: import (
|
Don't need to care about GetClusterWideKey, focus ClusterWideKeyFunc function |
Oh, I get what you mean now. |
Yes, the karmada doesn't have list objects, but would it be safer to replace the following code? |
I agree, but I think we can check if the group/version/kind is empty, but shouldn't add the schema parameter. /remove-kind bug |
Hi @RainbowMango |
Thanks @whitewindmills. Sure thing. We always follow But, given @xigang spotted this, I'm not sure if @xigang wants to have a try. @xigang Please let me know if you want help. @whitewindmills I guess we can wait for @xigang for a while(like, by the end of today), if no response from @xigang, then you can assign it to you, thanks in advance. By the way, if @xigang gonna take this, you still can help to review, that's also a worthy contribution. |
@RainbowMango Thanks, I can fix this issue. I recently submit a pr. :) |
@RainbowMango @whitewindmills PR has been submitted. #3288 |
What happened:
call ClusterWideKeyFunc() method don't get runtime.Object GVK information.
code: https://github.com/karmada-io/karmada/blob/master/pkg/util/fedinformer/keys/keys.go#L63
Test code output:
What you expected to happen:
Expect to get GVK information from runtime.Object
How to reproduce it (as minimally and precisely as possible):
Test code:
The text was updated successfully, but these errors were encountered: