chore: update ESLint packages #3517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the changes are automatic fixes from `npm run lint:fix`. The only non-trivial change is to `.hasOwnProperty()`, which is now reported by recommended ESLint rules. See [no-prototype-builtins](https://eslint.org/docs/rules/no-prototype-builtins) for more details.
johnjbarton
approved these changes
May 18, 2020
|
Yeah, Don't like it either, but AFAICT there is no better alternative without changing the semantics of existing checks. I was also thinking to replace The other two occurrences are technically valid (although very unlikely). E.g. users can potentially add |
|
✅ Build karma 284 completed (commit 6facb13048 by @devoto13) |
|
✅ Build karma 285 completed (commit 6facb13048 by @devoto13) |
|
@johnjbarton Is there something you expect from me before merging or just want to give it more thought? |
|
🎉 This PR is included in version 5.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
anthony-redFox
pushed a commit
to anthony-redFox/karma
that referenced
this pull request
May 16, 2023
Most of the changes are automatic fixes from `npm run lint:fix`. The only non-trivial change is to `.hasOwnProperty()`, which is now reported by recommended ESLint rules. See [no-prototype-builtins](https://eslint.org/docs/rules/no-prototype-builtins) for more details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the changes are automatic fixes from
npm run lint:fix. The only non-trivial change is to.hasOwnProperty(), which is now reported by recommended ESLint rules. See no-prototype-builtins for more details.