Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runner): Fix loading of external scripts without cors headers #2318

Merged
merged 1 commit into from
Sep 14, 2016

Conversation

dotch
Copy link
Contributor

@dotch dotch commented Aug 16, 2016

As described in #2249, external scripts without the necessary Access-Control-Allow-Origin header are rejected with:

Script from origin '...' has been blocked from loading by 
Cross-Origin Resource Sharing policy: 
No 'Access-Control-Allow-Origin' header is present on the 
requested resource. Origin '...' is therefore not allowed access.

This PR reverts the change that introduced this behavior.

If we want to keep the benefits that were introduced with #2219 we could create a configuration option for this.
In that case we'd have to decide what we want as a default behavior.

@dignifiedquire
Copy link
Member

Let's keep the current behaviour as the default one, and allow to disable it via configuration.

@dotch
Copy link
Contributor Author

dotch commented Sep 9, 2016

I added a crossOriginAttribute configuration option. (open to better naming)

This enables the loading of external scripts without the
required CORS headers being set.
@dignifiedquire
Copy link
Member

Thanks :octocat: I'm afraid I don't have any better name ideas either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants