feat: Fail on load-errors. #1931
Conversation
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
|
@srawlins, can you sign the CLA? |
|
@nikku does not like that change for the reason you mentioned ( Isn't there another way to implement that in a backward compatible manner? |
|
@nikku Sorry for the indirection. |
budde377
force-pushed
the
issue-855-fail-on-load-errors
branch
2 times, most recently
from
21a3e46
to
cd24d95
Compare
|
@budde377 is this ready for review? |
|
@dignifiedquire, yes. I don't know what to do about the missing CLA from @srawlins. |
budde377
force-pushed
the
issue-855-fail-on-load-errors
branch
from
cd24d95
to
dfe9943
Compare
|
CLAs look good, thanks! |
budde377
force-pushed
the
issue-855-fail-on-load-errors
branch
3 times, most recently
from
3903dbc
to
9c705a7
Compare
| @@ -11,7 +11,7 @@ var processDecorator = require('./launchers/process').decoratorFactory | |||
|
|
|||
| // TODO(vojta): remove once nobody uses it | |||
| var baseBrowserDecoratorFactory = function (baseLauncherDecorator, captureTimeoutLauncherDecorator, | |||
| retryLauncherDecorator, processLauncherDecorator) { | |||
| retryLauncherDecorator, processLauncherDecorator) { | |||
There was a problem hiding this comment.
Let's not do this please, instead use this indentation:
var name = function (
arg1,
arg2,
arg3
) {
// body
}
…ors. Stop karma if a launcher, reporter, plugin, or preprocessor fails to load, after attempting to load each of them, and reporting errors for each load error. Closes karma-runner#855
budde377
force-pushed
the
issue-855-fail-on-load-errors
branch
from
9c705a7
to
fca930e
Compare
|
Closes #855 |
feat: Fail on load-errors.
|
@dignifiedquire I just want to notice, that I didn't do the whole extract server from injector thing, so we might see some launchers breaking if they rely on the signature of the launcer. |
|
@budde377 yeah I realised that, but I wanted to get it in, will fix reporters when they tell us, this is not really documented stable api anyway |
Stop karma if a launcher, reporter, plugin, or preprocessor fails to
load, after attempting to load each of them, and reporting errors for
each load error.
Also someone should prob. tell @nikku that the karma-browserify
plugin is going to stop working due the changed signature of
createPreprocessor.Closes #855