fix(client): Wait for iframe to be loaded #1653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to wait for the iframe to be loaded before we can set reloadingContext to false. Closes karma-runner#1652
|
👍 verified it works with jashkenas/backbone#3832 |
dignifiedquire
added a commit
that referenced
this pull request
Oct 22, 2015
fix(client): Wait for iframe to be loaded
|
Released as |
|
Also verified. Thanks for coming together on this guys. |
|
Refer to #1655 for related non-iframe config fix. |
megawac
added a commit
to jashkenas/backbone
that referenced
this pull request
Oct 23, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to wait for the iframe to be loaded before we can set
reloadingContext to false.
Closes #1652