feat(launcher): Add concurrency limit #1646
Conversation
|
LGTM |
|
There were the following issues with your Pull Request
Guidelines are available at http://karma-runner.github.io/0.13/dev/git-commit-msg.html This message was auto-generated by https://gitcop.com |
|
Amazing feature! |
Especially services like Browserstack and SauceLabs have limitations on how many browsers can be launched at the same time. The new config option `concurrency` allows to specify an upper limit of how many browsers are allowed to run at the same time. Ref: karma-runner/karma-sauce-launcher#40 Closes karma-runner#1465
dignifiedquire
force-pushed
the
concurrent
branch
from
77b2a8c
to
1741deb
Compare
|
@zzo all done :) |
|
|
||
| // Concurrency level | ||
| // how many browser should be started simultanous | ||
| concurrency: Infinity |
|
lgtm - merge away |
|
SWEEEET! :D This looks awesome! Will be super useful to test the WebRTC Web Applications Great work! |
feat(launcher): Add concurrency limit
|
Excited to finally have this. Thanks! |
|
🍻 thanks! I attempted a similar patch last year but failed to get all the cases working |
|
@dignifiedquire Any way to have Karma implicitly set the default (unset) value to match the user's max concurrency limit (retrieved via the REST API) rather than |
|
I'm unclear what REST api you mean, karma does not have one. |
|
Nevermind, I just noticed this ended up in Karma core rather than |
Especially services like Browserstack and SauceLabs have limitations on
how many browsers
can be launched at the same time. The new config option
concurrencyallows to
specify an upper limit of how many browsers are allowed to run at the
same time.
Ref: karma-runner/karma-sauce-launcher#40
Closes #1465