Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: small spelling fix #1616

Merged
merged 1 commit into from
Oct 13, 2015
Merged

style: small spelling fix #1616

merged 1 commit into from
Oct 13, 2015

Conversation

DarthCharles
Copy link
Contributor

Small typos I encountered while checking the code. Hope it helps :)

@GitCop
Copy link

GitCop commented Oct 12, 2015

There were the following issues with your Pull Request

  • Commit: 343e64d
    • Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at http://karma-runner.github.io/0.13/dev/git-commit-msg.html


This message was auto-generated by https://gitcop.com

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@DarthCharles DarthCharles changed the title small spelling fix %{type}(%{scope}): %{description} Oct 12, 2015
@DarthCharles DarthCharles changed the title %{type}(%{scope}): %{description} typo Oct 12, 2015
@DarthCharles DarthCharles deleted the spelling-fix branch October 12, 2015 05:10
@DarthCharles DarthCharles restored the spelling-fix branch October 12, 2015 05:12
@DarthCharles DarthCharles reopened this Oct 12, 2015
@DarthCharles DarthCharles changed the title typo style:fix typos Oct 12, 2015
@dignifiedquire
Copy link
Member

Thanks, the bot was referring to the commit message itself though, not the title of the PR. You can change that by using either git amend or git rebase -i, see here for details

@GitCop
Copy link

GitCop commented Oct 12, 2015

There were the following issues with your Pull Request

  • Commit: 343e64d
    • Commits must be in the following format: %{type}(%{scope}): %{description}
  • Commit: bd3e214
    • Commits must be in the following format: %{type}(%{scope}): %{description}
  • Commit: 83df51d
    • Commits must be in the following format: %{type}(%{scope}): %{description}
    • Your subject line is longer than 70 characters

Guidelines are available at http://karma-runner.github.io/0.13/dev/git-commit-msg.html


This message was auto-generated by https://gitcop.com

@googlebot
Copy link

CLAs look good, thanks!

@GitCop
Copy link

GitCop commented Oct 12, 2015

There were the following issues with your Pull Request

  • Commit: 343e64d
    • Commits must be in the following format: %{type}(%{scope}): %{description}
  • Commit: bd3e214
    • Commits must be in the following format: %{type}(%{scope}): %{description}
  • Commit: 83df51d
    • Commits must be in the following format: %{type}(%{scope}): %{description}
    • Your subject line is longer than 70 characters
  • Commit: ea59053
    • Commits must be in the following format: %{type}(%{scope}): %{description}
  • Commit: ddcd3b4
    • Commits must be in the following format: %{type}(%{scope}): %{description}
    • Your subject line is longer than 70 characters

Guidelines are available at http://karma-runner.github.io/0.13/dev/git-commit-msg.html


This message was auto-generated by https://gitcop.com

style: small spelling fix
@GitCop
Copy link

GitCop commented Oct 13, 2015

There were the following issues with your Pull Request

  • Commit: f30bf97
    • Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at http://karma-runner.github.io/0.13/dev/git-commit-msg.html


This message was auto-generated by https://gitcop.com

@DarthCharles DarthCharles changed the title style:fix typos style: small spelling fix Oct 13, 2015
@DarthCharles
Copy link
Contributor Author

@dignifiedquire I think I'm messing things up here.

@dignifiedquire
Copy link
Member

All good now thanks, the bot is not too clever ;)

dignifiedquire added a commit that referenced this pull request Oct 13, 2015
@dignifiedquire dignifiedquire merged commit 0863bb6 into karma-runner:master Oct 13, 2015
@dignifiedquire
Copy link
Member

:octocat:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants