-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add finish timestamp for every browser #1358
Conversation
Thanks, can you please change the commit message following this git commit message convention. |
var date = new Date(); | ||
var hours = date.getHours() < 10 ? '0' + date.getHours() : date.getHours(); | ||
var minutes = date.getMinutes() < 10 ? '0' + date.getMinutes() : date.getMinutes(); | ||
var seconds = date.getSeconds() < 10 ? '0' + date.getSeconds() : date.getSeconds(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@theghostbel we can improve code little:
var finishDate = new Date();
var formatTime = function(date) { return time < 10 ? '0' + time : time};
msg += util.format(' finished at %s:%s:%s', formatTime(formatTime.getHours()), formatTime(finishDate.getMinutes()), formatTime(finishDate.getSeconds()));
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed
@theghostbel could you fix the code formatting issues that came up on travis please? |
@dignifiedquire fixed, thanks for pointing! |
Now all that's missing is to squash it into on commit then it's good to go from my side. |
See in console time (HH:MM:SS) when run completed. This helps in situations when looking into console and don't know if current results are the freshest
Squashed commits into one. For those who is searching "how to" squash commits for github`s pull request into one I'd recommend this article. Worked like a charm after I switched to simple push mechanism for forced pushes:
@dignifiedquire, how to be when one of builds failed? :( Looks like it was kinda test build env ("iojs-1") |
@theghostbel I've retriggered it lets see with what it comes back |
@theghostbel could you rebase onto the latest master please? |
@theghostbel ping |
pong, one month routetrip :) not bad |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
Hi! |
Being applied we can see in console time (HH:MM:SS) when run completed. This helps in situations when you work for a while over some file and then look into console and don't know if current results are the freshest? You throw a look on clocks and realise - hey! it's five minutes old! I've forgot to click "CTRL+S"