Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add finish timestamp for every browser #1358

Closed
wants to merge 1 commit into from

Conversation

theghostbel
Copy link

Being applied we can see in console time (HH:MM:SS) when run completed. This helps in situations when you work for a while over some file and then look into console and don't know if current results are the freshest? You throw a look on clocks and realise - hey! it's five minutes old! I've forgot to click "CTRL+S"

Firefox 34.0.0 (Windows 7): Executed 98 of 98 (2 FAILED) (8.926 secs / 8.867 secs) finished at 01:16:27

@dignifiedquire
Copy link
Member

Thanks, can you please change the commit message following this git commit message convention.

var date = new Date();
var hours = date.getHours() < 10 ? '0' + date.getHours() : date.getHours();
var minutes = date.getMinutes() < 10 ? '0' + date.getMinutes() : date.getMinutes();
var seconds = date.getSeconds() < 10 ? '0' + date.getSeconds() : date.getSeconds();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@theghostbel we can improve code little:

var finishDate = new Date();
var formatTime = function(date) { return time < 10 ? '0' + time : time};
msg += util.format(' finished at %s:%s:%s', formatTime(formatTime.getHours()), formatTime(finishDate.getMinutes()), formatTime(finishDate.getSeconds()));

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed

@dignifiedquire
Copy link
Member

@theghostbel could you fix the code formatting issues that came up on travis please?

@theghostbel
Copy link
Author

@dignifiedquire fixed, thanks for pointing!

@dignifiedquire
Copy link
Member

Now all that's missing is to squash it into on commit then it's good to go from my side.

See in console time (HH:MM:SS) when run completed. This helps in situations
when looking into console and don't know if current results are the freshest
@theghostbel
Copy link
Author

Squashed commits into one. For those who is searching "how to" squash commits for github`s pull request into one I'd recommend this article. Worked like a charm after I switched to simple push mechanism for forced pushes:

$ git config --global push.default simple
$ git push -f

@dignifiedquire, how to be when one of builds failed? :( Looks like it was kinda test build env ("iojs-1")

@dignifiedquire
Copy link
Member

@theghostbel I've retriggered it lets see with what it comes back

@dignifiedquire
Copy link
Member

@theghostbel could you rebase onto the latest master please?

@dignifiedquire dignifiedquire changed the title Add finish timestamp for every browser feat: Add finish timestamp for every browser Jun 4, 2015
@dignifiedquire
Copy link
Member

@theghostbel ping

@theghostbel
Copy link
Author

pong, one month routetrip :) not bad
will try to do this tomorrow, not a big fan console git, prefer hg with it's GUI :)

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@theghostbel
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@theghostbel
Copy link
Author

theghostbel commented Oct 19, 2016

Hi!
@maksimr @dignifiedquire,
Any plan to merge this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants