Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(preprocessor): add 'mp3' and 'ogg' as binary formats #1103

Merged
merged 1 commit into from
Jun 19, 2014
Merged

feat(preprocessor): add 'mp3' and 'ogg' as binary formats #1103

merged 1 commit into from
Jun 19, 2014

Conversation

thom4parisot
Copy link
Contributor

Avoids media corruption in the browser.

@cironunes
Copy link
Member

LGTM

1 similar comment
@maksimr
Copy link
Contributor

maksimr commented Jun 19, 2014

LGTM

@thom4parisot
Copy link
Contributor Author

Cool. The reason I raised that issue is because I wanted to test HTML Audio objects and the files were not playable nor were exposing metadata (like duration and so on) because every single browser would consider them as corrupted (and of course it is the case as they are sent as text and not binary).

maksimr added a commit that referenced this pull request Jun 19, 2014
feat(preprocessor): add 'mp3' and 'ogg' as binary formats
@maksimr maksimr merged commit c071305 into karma-runner:master Jun 19, 2014
@thom4parisot thom4parisot deleted the patch-1 branch June 20, 2014 09:33
@thom4parisot
Copy link
Contributor Author

Any chance to get it released as v0.12.17 or behind the @dev or @canary flag?

Because for some reasons the following fails to work on TravisCI (the Gruntfile.coffee is missing whereas on my machine it's okay):

npm install git+https://github.com/karma-runner/karma.git#c071305b08f0dcb3cac1b9a04e6feefbbde13882
cd node_modules/karma
npm install
grunt build # fails because Gruntfile.coffee does not exist
$ npm show karma | head
{ name: 'karma',
  description: 'Spectacular Test Runner for JavaScript.',
  'dist-tags':
   { 'canary-dart': '0.9.2-dart',
     latest: '0.12.16',
     canary: '0.12.11-beta-3029418',
     dev: '0.11.12-dev2',
     old: '0.10.10' },
  versions:

Thanks :-)

@maksimr
Copy link
Contributor

maksimr commented Jun 24, 2014

@oncletom It should automatically released into the “canary” channel.
But seems auto-release is broken

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants