-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix (proxy): Default to karma port and host #1007
Conversation
\cc @vojtajina |
proxyConfig[proxyPath].port = proxyConfig[proxyPath].https ? '443' : '80'; | ||
proxyConfig[proxyPath].port = !proxyConfig[proxyPath].host ? ( | ||
(proxyConfig[proxyPath].host = constant.DEFAULT_HOSTNAME) && constant.DEFAULT_PORT) | ||
: proxyConfig[proxyPath].https ? '443' : '80'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it'd be easier to read if you'd split this code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Thanks @deepak1556 !!! |
Otherwise LGTM. |
Fixed and squashed, Thanks @aymericbeaumet and @vojtajina. Ahh damn i messed up the commit message, is there a way to fix just tat ? |
fix (proxy): Default to karma port and host
I'm afraid that everything's pushed is definitely pushed :/ |
|
Well You will not be able to push it without |
ahh yeah tats a bad way though bt its not a problem if no one is working on the same branch, i guess. |
That's not a problem from the moment nobody's fetched your work. |
Force push to your branch is OK. Just don't force push to master/stable branches. |
👍 |
Closes #872