Clarify "Some of your tests did a full page reload!"

[Wilfred]

If I'm debugging some hairy code I sometimes see this error. It would be really helpful if Karma said what URL my tests tried to navigate to.

[davidlinse]

👍

[ruffrey]

+1 please

[fabien0102]

+1

[maksimr]

This is not so simple, I think.

1. When in your code called location.reload() URL is not so helpful.
2. When you call location = 'test' we can not get new location in beforeunload callback

How described in comment more helpful will be have name of test which cause reload.
But I think it adapter issue also, because adapter has more information about tests.

Thanks!

[matteofigus]

+1, even the test would be great!

[n1k0]

+100000^100000 this is turning me crazy.

[ajbogh]

+1 - I have over 1700 tests that run on a very large app. Since the error doesn't say which test did the reload, or what line of code caused the reload, I'm going to have to go through all of my spec files and ddescribe every file until I find the file that's causing the problem. Once there I'll have to iit every test until I find the culprit. It would be much better if Karma could just say which test name caused the problem, or even go so far as to show the line in the code.

[Wilfred]

@maksimr would calling console.trace() help?

[chfw]

+1. It would help if Karma could tell which test case did a full page reload.

[surajk]

+1 please

[ghost]

+1. I am encountering this on unit tests that are never injecting the $window or $location object, and not sure how page reloads could be happening.

It is very rare and I cannot reproduce consistently unfortunately. More info in the error would really help out.

[jseto]

@trov-codystebbins
I have exactly the same problem as you. It happens only in autoWatch mode when reloading after an error when testing directives but NOT injecting $location nor $window.

To work around, I exit from karma and run again. Always get rid of the message with no further action. but anoying... :(

[pablo-zocdoc]

+1

[dineshWizni]

Hi I am facing the same issue , at one place I have window.location.href in my code (when I do not find something stored in the cookie , I redirect it to some page) , but it has nothing to do with my test cases. And I am getting this error. Any help plzzz?

[jywu]

Is this being fixed? I'm also having the error even though I do not reload the page in my unit tests (I do have window.location.replace(URL) in my application.) Any help?

[hulufei]

+1

[bensampaio]

I'm also experiencing this behaviour and I'm quite sure I have no reloads on my tests.

I don't know if this could be the problem but I'm using webpack and babel alongside karma. When I change any spec file I always get the full page reload error, but all other files are ok (I mean, Karma detects the changes and run the tests again without any reload).

I have to constantly restart karma which is really not productive... Any ideas?

[mkolodny]

+1

[booleanbetrayal]

+1

[Furizaa]

I've gotten this error on every change to one simple test expect(true).toBe(true); using webpack and babel. In the end I got this working by using exactly the same setup the react-router project is using (versions of karma-* packages, karma.conf). No problems so far.

https://github.com/rackt/react-router/blob/master/package.json#L41
https://github.com/rackt/react-router/blob/master/karma.conf.js

[kylechadha]

+1

[mqklin]

+1
Try to reduce amount of describe sections. I don't know why, but it's work for me.

[gabrieledarrigo]

+1

[ikr0m]

+1

[VictorQueiroz]

I was on the same issue. Then I removed the window event "beforeunload" and everything is running just fine now...

[nbrustein]

@VictorQueiroz I tried removing all of our beforeunload handling but am still seeing the issue. Then again, I guess this ticket is less about preventing the issue and more about being specific about where it's coming from anyway.

Thanks for the suggestion, anyway.

[haibei-victor-wu]

+1 does someone know the problem

[mqklin]

@haibei-victor-wu, try to reduce the number of describe sections.

[JamieMason]

I hope this helps someone, you can track down causes of this issue with the following steps.

1. Run your app with the following code included before anything else and DevTools (Chrome, in this case) open.

console.profile('cause of reload');

window.addEventListener('beforeunload', function() {
    console.profileEnd('cause of reload');
    debugger;
});

If the reload you're looking for happens, you should be taken to the "Sources" view of Chrome Devtools with the app paused at the debugger line.

2. Navigate to "Profiles" tab and choose the "Charts" view.
3. Command+F and search for "location".
4. Use the up and down arrows in the search box to jump to the last occuring matches for that phrase.
5. Hit enter in the search field to jump to the match.
6. Look back through the call stack for code you recognise.

[MichaelFBA]

+1 this is so painful atm

[madstt]

I fought the same issue for some time. I came up with the following solution.

I your tests, before you inject anything, create a $window object and use $provide.value() to override the built-in $window object, like this:

beforeEach(function () {

  module('app');

  $window = {location: {reload: sinon.spy()}};

  module(function($provide) {
    $provide.value('$window', $window);
  });

  inject(function (...) {...} )

});

Instead of sinon.spy() you could use a variable of a sinon spy and use it in your assertions.

I hope this can help someone else.

[felix-d]

+1

[nebulou5]

Can someone confirm my thinking on this in this PR: #1648 This should at least address the issue of page reloads happening when a user isn't even messing with the location within a spec or dependency.

Refer to SHA: 471e3a8 for initial implementation of 'reloadingContext' flag and this stackoverflow post: http://stackoverflow.com/questions/29352578/some-of-your-tests-did-a-full-page-reload-error-when-running-jasmine-tests

[nebulou5]

To anyone who is getting this issue lately when your specs don't even mess with the location, it seems to be an issue with jasmine-core... refer to these issues: Refer to jasmine/jasmine#366 and jasmine/jasmine#945

[CaptainMat]

Any updates on this issue ? or workaround ? Jasmine issues are still open and the problem is still happening in karma 0.13.14.

[stefan-dimitrov]

+1

[timasjov]

Better error message will provided much more value.
As well I am getting this error when doing $window.location.reload(); 👎

[JamieMason]

Maybe I misunderstand @timasjov, but isn't $window.location.reload(); supposed to do a full page reload? You will probably want to mock that in your test.

[tkehayov]

+1

[ppalladino]

+1

[MarcoDeJong]

+1

[csvan]

+1

[dignifiedquire]

Please refrain from +1 this issue, I know it's important but there is no straightforward way to actually fix this in karma, as the architecture currently does not allow for this.

[lukaselmer]

+1