fix(file-list): do not preprocess up-to-date files (#3196)

It improves performance of "karma run" command which refreshes fileList. Closes #2829
karma-runner · Nov 14, 2018 · 5334d1a · 5334d1a
1 parent dc5f5de
commit 5334d1a
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/lib/file-list.js b/lib/file-list.js
@@ -102,6 +102,12 @@ class FileList {
           return Promise.resolve(file)
         }
 
+        const prevFile = this._findFile(path, patternObject)
+        if (prevFile && file.mtime <= prevFile.mtime) {
+          log.debug(`Not preprocessing "${path}" as file hasn't been changed since the last preprocessing`)
+          return Promise.resolve(prevFile)
+        }
+
         return this._preprocess(file).then(() => file)
       })
         .then((files) => {

diff --git a/test/unit/file-list.spec.js b/test/unit/file-list.spec.js
@@ -375,9 +375,15 @@ describe('FileList', () => {
         })
     })
 
-    it('preprocesses all files', () => {
+    it('preprocesses new and/or changed files', () => {
       return list.refresh().then((files) => {
         expect(preprocess.callCount).to.be.eql(5)
+        preprocess.resetHistory()
+        mg.statCache['/some/a.js'].mtime++
+        return list.refresh().then((files) => {
+          expect(preprocess.callCount).to.be.eql(1)
+          mg.statCache['/some/a.js'].mtime--
+        })
       })
     })