Support timeout mocks on ie8 #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vojtajina can you please look at it? |
|
@SevInf thanks! Can you change commit message following commit message style guide. Soon we change on peer dependency. |
See http://www.adequatelygood.com/Replacing-setTimeout-Globally.html for description of the problems and solutions. Jasmine's boot.js already has this hack. Closes karma-runner#41
SevInf
force-pushed
the
fix/timeout-ie8
branch
from
328e81d
to
4484b1a
Compare
|
@maksimr, done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See http://www.adequatelygood.com/Replacing-setTimeout-Globally.html
for description of the problems and solutions.
Jasmine's
boot.jsalready has this hack.Fix #41